<html>
<head><meta charset="utf-8"><title>Perf run for rustdoc? · t-infra · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/index.html">t-infra</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html">Perf run for rustdoc?</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="201508752"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/201508752" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#201508752">(Jun 21 2020 at 01:12)</a>:</h4>
<p>I know there are perf runs for the compiler, do those cover rustdoc as well? or is there a separate perf command for rustdoc? I have a feeling <a href="https://github.com/rust-lang/rust/pull/73566">https://github.com/rust-lang/rust/pull/73566</a> will affect perf a lot but I'm not sure if it will be better or worse.</p>



<a name="201509015"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/201509015" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#201509015">(Jun 21 2020 at 01:19)</a>:</h4>
<p>perf does not support rustdoc today (and there's not a great way to get perf for rustdoc through automated tooling). You could plausibly try it out yourself on some group of crates (say, std, core, winapi, serde)</p>



<a name="201509061"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/201509061" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#201509061">(Jun 21 2020 at 01:20)</a>:</h4>
<p>I'd personally be willing to take a PR adding a rustdoc mode to perf though as an opt-in thing</p>



<a name="201509069"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/201509069" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#201509069">(Jun 21 2020 at 01:21)</a>:</h4>
<p>neat! where would I make the PR to, is perf in-tree?</p>



<a name="201509088"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/201509088" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#201509088">(Jun 21 2020 at 01:21)</a>:</h4>
<p>no, <a href="https://github.com/rust-lang/rustc-perf/">https://github.com/rust-lang/rustc-perf/</a></p>



<a name="201509132"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/201509132" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#201509132">(Jun 21 2020 at 01:22)</a>:</h4>
<p>you probably want to take a look at collector, and to start just add it as one of the ways of gathering perf (you can grep for say cachegrind)</p>



<a name="201509143"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/201509143" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#201509143">(Jun 21 2020 at 01:22)</a>:</h4>
<p>or I guess, actually, no</p>



<a name="201509148"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/201509148" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#201509148">(Jun 21 2020 at 01:22)</a>:</h4>
<p>we'll want to add a dedicated buildkind (like check/debug/opt), called doc</p>



<a name="201509155"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/201509155" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#201509155">(Jun 21 2020 at 01:23)</a>:</h4>
<p>iirc that's a buildkind but it might be a runkind, I don't have the sources at the moment</p>



<a name="201509218"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/201509218" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#201509218">(Jun 21 2020 at 01:24)</a>:</h4>
<p>and that would be by default off</p>



<a name="201509304"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/201509304" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#201509304">(Jun 21 2020 at 01:26)</a>:</h4>
<p>I imagine once you have that added it'd be not too hard to pull that support through (probably just following compiler errors) and then you can run perf locally via something like <code>./target/release/collector --db rustdoc.db --filter hyper -- bench_local --rustc ~/.rustup/bin/toolchains/stage1/bin/rustdoc --cargo ~/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/bin/cargo --id stage1</code></p>



<a name="201509320"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/201509320" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#201509320">(Jun 21 2020 at 01:27)</a>:</h4>
<p>(The filter is of course optional, but you probably want it to speed up iterations initially)</p>



<a name="201509828"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/201509828" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#201509828">(Jun 21 2020 at 01:39)</a>:</h4>
<p><code>RunKind</code> is {Full, IncrementalFull, IncrementalUnchanged, IncrementalPatched} so I think I want BuildKind</p>



<a name="201509888"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/201509888" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#201509888">(Jun 21 2020 at 01:40)</a>:</h4>
<p>Yep</p>



<a name="201509906"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/201509906" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#201509906">(Jun 21 2020 at 01:41)</a>:</h4>
<p><span class="user-mention" data-user-id="232545">@Joshua Nelson</span> FWIW I plan to dedicate an hour or two at least to perf tomorrow, so if you get partway please do post a PR (or all the way of course is fine too :)</p>



<a name="201509953"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/201509953" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#201509953">(Jun 21 2020 at 01:42)</a>:</h4>
<p>the readme for <code>collector</code> seems to be out of date, it builds fine on stable</p>



<a name="201510419"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/201510419" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#201510419">(Jun 21 2020 at 01:56)</a>:</h4>
<p>btw I won't have much time to work on this today or tomorrow so don't wait on me for changes to perf</p>



<a name="201539569"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/201539569" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#201539569">(Jun 21 2020 at 15:42)</a>:</h4>
<p>Nightly is mainly because we used to rely on nightly cargo for compat with master builds, but I think that's no longer true). Regardless, our CI doesn't test stable though we do try to keep compat.</p>



<a name="202160543"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/202160543" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#202160543">(Jun 27 2020 at 01:18)</a>:</h4>
<p>I'm not quite sure what I should do in <code>run_rustc</code></p>



<a name="202160545"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/202160545" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#202160545">(Jun 27 2020 at 01:18)</a>:</h4>
<p>I can only add arguments, not change the command being run, which is hardcoded to <code>rustc</code></p>



<a name="202160573"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/202160573" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#202160573">(Jun 27 2020 at 01:19)</a>:</h4>
<p>oh hold on I think I can modify <code>subcommand</code></p>



<a name="202161586"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/202161586" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#202161586">(Jun 27 2020 at 01:47)</a>:</h4>
<p>modifying subcommand did not do what I wanted</p>
<div class="codehilite"><pre><span></span><code>$ RUST_LOG=debug $CARGO_TARGET_DIR/release/collector --db rustdoc.db --filter hyper -- bench_local --rustc ~/.rustup/bin/toolchains/stage1/bin/rustdoc --cargo ~/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/bin/cargo --id stage1
error: The subcommand &#39;bench_local&#39; wasn&#39;t recognized
    Did you mean &#39;bench_local&#39;?

If you believe you received this message in error, try re-running with &#39;collector -- bench_local&#39;

USAGE:
    collector --db &lt;db&gt; --filter &lt;filter&gt;
</code></pre></div>



<a name="202161714"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/202161714" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#202161714">(Jun 27 2020 at 01:51)</a>:</h4>
<p>wait that happens without my changes too</p>



<a name="202161718"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/202161718" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#202161718">(Jun 27 2020 at 01:51)</a>:</h4>
<p>I'm very confused</p>



<a name="202162097"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/202162097" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#202162097">(Jun 27 2020 at 01:59)</a>:</h4>
<p>ok the command line that worked on master was</p>
<div class="codehilite"><pre><span></span><code>$ cargo +nightly build --release &amp;&amp; RUST_LOG=debug $CARGO_TARGET_DIR/release/collector --db rustc.db --filter hyper bench_local --rustc $RUSTUP_HOME/toolchains/stage1/bin/rustc --cargo $RUSTUP_HOME/toolchains/nightly-x86_64-unknown-linux-gnu/bin/cargo rustc
</code></pre></div>



<a name="202162109"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/202162109" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#202162109">(Jun 27 2020 at 01:59)</a>:</h4>
<p>passing rustdoc instead of rustc gives</p>
<div class="codehilite"><pre><span></span><code>stderr=error: failed to run `rustc` to learn about target-specific information

Caused by:
  process didn&#39;t exit successfully: `/home/joshua/.local/lib/cargo/target/release/rustc-fake - --crate-name ___ --print=file-names --crate-type bin --crate-type rlib --crate-type dylib --crate-type cdylib --crate-type staticlib --crate-type proc-macro --print=sysroot --print=cfg` (exit code: 1)
--- stderr
error: Unrecognized option: &#39;print&#39;
</code></pre></div>



<a name="202162327"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/202162327" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#202162327">(Jun 27 2020 at 02:04)</a>:</h4>
<p>maybe collector should take a directory instead of a binary so it can call <code>rustc --print=cfg</code> even when profiling rustdoc</p>



<a name="202163403"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/202163403" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#202163403">(Jun 27 2020 at 02:33)</a>:</h4>
<p>I tried not telling it that rustdoc was rustc and that got me a little further</p>
<div class="codehilite"><pre><span></span><code>$ cargo +nightly build --release &amp;&amp; rm -f rustdoc.db &amp;&amp; RUST_BACKTRACE=1 RUST_LOG=debug $CARGO_TARGET_DIR/release/collector --db rustdoc.db --filter hyper bench_local --rustc $RUSTUP_HOME/toolchains/stage1/bin/rustc --cargo $RUSTUP_HOME/toolchains/nightly-x86_64-unknown-linux-gnu/bin/cargo --builds Doc rustdoc
[2020-06-27T02:29:43Z DEBUG collector::execute] &quot;/home/joshua/.local/lib/rustup/toolchains/nightly-x86_64-unknown-linux-gnu/bin/cargo&quot; &quot;doc&quot; &quot;--manifest-path&quot; &quot;Cargo.toml&quot; &quot;-p&quot; &quot;file:///tmp/.tmpItLuQ9#hyper:0.13.0-alpha.4&quot; &quot;--&quot; &quot;--wrap-rustc-with&quot; &quot;perf-stat&quot;
Failed to benchmark hyper-2, recorded: expected success, got exit code: 1

stderr=error: Found argument &#39;--wrap-rustc-with&#39; which wasn&#39;t expected, or isn&#39;t valid in this context

USAGE:
    cargo doc --manifest-path &lt;PATH&gt; --package &lt;SPEC&gt;...
</code></pre></div>



<a name="202163468"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/202163468" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#202163468">(Jun 27 2020 at 02:34)</a>:</h4>
<p>oh ugh there's a <code>rustc-fake</code> but there's no <code>rustdoc-fake</code></p>



<a name="202163470"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/202163470" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#202163470">(Jun 27 2020 at 02:34)</a>:</h4>
<p>what is rustc-fake used for?</p>



<a name="202163732"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/202163732" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#202163732">(Jun 27 2020 at 02:41)</a>:</h4>
<p>I tried setting the <code>RUSTDOC</code> env var but no dice</p>



<a name="202164964"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/202164964" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#202164964">(Jun 27 2020 at 03:18)</a>:</h4>
<p>it looks like cargo is giving this error <em>before spawning rustdoc</em></p>



<a name="202164967"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/202164967" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#202164967">(Jun 27 2020 at 03:19)</a>:</h4>
<p>I'm so confused, maybe I should use RUSTDOCFLAGS instead</p>



<a name="202165126"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/202165126" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#202165126">(Jun 27 2020 at 03:23)</a>:</h4>
<p>yay that got me a different error!</p>



<a name="202165164"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/202165164" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#202165164">(Jun 27 2020 at 03:24)</a>:</h4>
<div class="codehilite"><pre><span></span><code>error: the generated executable for the input file &quot;/home/joshua/.cargo/registry/src/github.com-1ecc6299db9ec823/cfg-if-0.1.10/src/lib.rs&quot; conflicts with the existing directory &quot;/tmp/.tmpPp0ha0/target/doc&quot;

error: aborting due to previous error

thread &#39;main&#39; panicked at &#39;assertion failed: status.success()&#39;, collector/src/bin/rustc-fake.rs:56:17
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
error: Could not document `cfg-if`
</code></pre></div>



<a name="202165541"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/202165541" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#202165541">(Jun 27 2020 at 03:37)</a>:</h4>
<p>the issue I think is <code>rustc-fake</code> is being rustc, not rustdoc. I need to split the two apart</p>



<a name="202166163"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/202166163" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#202166163">(Jun 27 2020 at 03:57)</a>:</h4>
<p>right, so that gave me</p>
<div class="codehilite"><pre><span></span><code>error: Unrecognized option: &#39;emit&#39;

error: could not compile `unicode-xid`.

To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
</code></pre></div>


<p>but also <em>at the same time</em></p>
<div class="codehilite"><pre><span></span><code>error: the generated executable for the input file &quot;/home/joshua/.cargo/registry/src/github.com-1ecc6299db9ec823/cfg-if-0.1.10/src/lib.rs&quot; conflicts with the existing directory &quot;/tmp/.tmpFuZc0k/target/doc&quot;

error: aborting due to previous error
</code></pre></div>


<p>which is an error from rustc. So I'm very confused.</p>



<a name="202166478"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/202166478" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#202166478">(Jun 27 2020 at 04:07)</a>:</h4>
<p>oh I might have figured it out - environment variables are global within a process, so if cargo invokes both <code>rustc</code> and <code>rustdoc</code> then since I hacked <code>ACTUALLY_RUSTDOC=1</code> rustc-fake will <em>always</em> think it's rustdoc</p>



<a name="202166635"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/202166635" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#202166635">(Jun 27 2020 at 04:13)</a>:</h4>
<p>oops I had a different bug, now it consistently gives the 'emit' error</p>



<a name="202167396"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/202167396" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#202167396">(Jun 27 2020 at 04:35)</a>:</h4>
<p>hey it might be working :D</p>



<a name="202167447"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/202167447" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#202167447">(Jun 27 2020 at 04:36)</a>:</h4>
<p><a href="https://github.com/jyn514/rustc-perf/tree/rustdoc">https://github.com/jyn514/rustc-perf/tree/rustdoc</a></p>



<a name="202190082"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Perf%20run%20for%20rustdoc%3F/near/202190082" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Perf.20run.20for.20rustdoc.3F.html#202190082">(Jun 27 2020 at 15:03)</a>:</h4>
<p><a href="https://github.com/rust-lang/rustc-perf/pull/675">https://github.com/rust-lang/rustc-perf/pull/675</a></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>